Fix issues with undefined/null trivia items#1531
Merged
TwitchBronBron merged 1 commit intov1from Jul 16, 2025
Merged
Conversation
TwitchBronBron
added
the
create-package
Contributor
|
Hey there! I just built a new temporary npm package based on e88b420. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.47-fix-trivia-crash.20250715203545.tgz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several issues related to trivia arrays containing
undefined. If plugins decide to useeditor.removePropertyinsead ofeditor.arraySplice, then those array entries are turned intoundefined, and that was crashing the transpiler. This makes those functions more resilient.Also updates the plugin docs to have a more accurate comment stripping plugin example.